search

TEIC / Stylesheets

TEI XSL Stylesheets
231 stars 124 forks source link

Look in <idno> as well as <altIdent> for module FPI #510

Closed sydb closed 2 years ago

sydb commented 3 years ago

Use more complex XPath to take child <idno> if there is one, child <altIdent> if not, as portion of FPI.

sydb commented 3 years ago

Adding @martindholmes to review changes in Test2/.

sydb commented 3 years ago

Just to have a place to put <altIdent> and <idno>! :-)

martindholmes commented 3 years ago

Ah, I see! No impact at all on expected-results from this?

sydb commented 3 years ago

Right, none other than those to Test2/expected-results/testNonTeiOdd1.rng, which are entirely from the whitespace commit, not the actual change.

sydb commented 3 years ago

Made this high priority, because it is blocking most further work on TEIC/TEI#2049.

martindholmes commented 3 years ago

I'm happy with it, but I think someone else from Council should approve too.

sydb commented 3 years ago

Agreed.

sydb commented 3 years ago

BTW, @hcayless, @peterstadler, and anyone else looking at this closely, you mostly want to look at the changes to odds/odd2dtd.xsl. The other changes are to a test file and its RNG output which a) is not as vital, and b) @martindholmes has already looked at. If you do look at the ODD and RNG files, I deliberately checked in whitespace changes separately to try to make comparing the real changes easier. Of course, I don’t know how to do that comparison here on GitHub. Care to enlighten me?