Fix for #520 - Githubissues

TEIC / Stylesheets

TEI XSL Stylesheets

231 stars 124 forks source link

Fix for #520 #521

Closed HelenaSabel closed 3 years ago

HelenaSabel commented 3 years ago

Syd’s fix for #520: it adds processing of @xml:id to the application of templates from <biblStruct> or <bibl>child of <listBibl>.

sydb commented 3 years ago

IMHO:

This PR must be reviewed by someone other than @sydb and @HelenaSabel, and must be merged prior to release.
Once a reviewer says go ahead, I think anybody can merge it in pronto, it does not require both reviewers to OK.

martinascholger commented 3 years ago

I can confirm that the links from examples to BIB work in my local build. But there is no tooltip anymore (maybe only in my local version?).

sydb commented 3 years ago

Futhermucker. Do you think lack of tool-tips is just high priority, or outright release blocking?

HelenaSabel commented 3 years ago

Same thing happens in my local installation as well, @martinascholger . I took a quick look at @martindholmes JavaScript and I don’t see the problem: the parameter that it is being sent to the function showPopupBibl() matches an @id in BIBL.html. I don’t know why it defaults to linking to the bibliography (without showing the popup). I will take a closer look tonight.

martindholmes commented 3 years ago

This is normal browser behaviour. AJAX won't run on you local machine, only when the page is coming from a server. It's not broken.:)

sydb commented 3 years ago

… I'm struggling to figure out what the original $id variable was supposed to be doing: <xsl:variable name="id" select="@xml:id"/> As far as I can see, it was never used, so something was already broken here. Do you see any use for it?

I saw so little use for it, I deleted it. :grin:

peterstadler commented 3 years ago

Thanks to @sydb and @HelenaSabel trying to explain the issue and the fix during todays Stylesheets meeting! It involves importing this Stylesheet into the Guidelines' build (https://github.com/TEIC/TEI/blob/59a2becc4a35f4a50a2518c605e1adef310e9f2c/P5/Utilities/guidelines.xsl.model#L20-L21) and some more intricacies. @sydb put it so: "We had to concede, in the end, that we are not entirely sure how this ever worked before these changes"