search

TEIC / Stylesheets

TEI XSL Stylesheets
231 stars 124 forks source link

Adding @classpathref to all XSLT calls #550

Closed HelenaSabel closed 2 years ago

HelenaSabel commented 2 years ago

PR for issue #544.

I’ve just tested this branch, and it should be noted that the author of the original issue (@bwbohl ) has tested it as well so I think it can be merged without requiring additional reviews.

ebeshero commented 2 years ago

In case a reviewer is wanted, I just read it all and am glad it was such a simple implementation. @classpathref seems like it could be useful in other scenarios requiring dependencies, too.

sydb commented 2 years ago

I do not really understand the problem or the solution, but 4 others (@bwbohl, @martindholmes, @HelenaSabel, and @ebeshero) all seem to be happy with this, and it has not broken anything. So, I think it can be merged toot sweet. (I just checked it out and merged in latest from dev, there was nothing to merge.)

bwbohl commented 2 years ago

@sydb, thanks for merging! Just my two cents on it: with the classpathref the TEI Stylesheets can be called from external scripts that will submit the classpath location. So basically, this is about increasing reusability.