TEIC / Stylesheets

TEI XSL Stylesheets
231 stars 124 forks source link

<egXML> in ODD to XHTML #553

Closed ddenison-man closed 1 year ago

ddenison-man commented 2 years ago

Until March 2022, a multi-line example of XML coding wrapped in <egXML> ... </egXML> in the ODD file had every new line left-aligned when displayed in XHTML. Now, using TEI P5 16.0.0, such examples are displayed with only the first line at the left edge and all subsequent lines hugely indented by 20 spaces. Alex Jitianu of Oxygen tells me 'It looks like it's something introduced in the 7.53.0 which comes bundled into the 16.0.0. addon'. A simple example is given below, before and after. Please can this be corrected. Thanks David Denison

image image

sydb commented 2 years ago

@ddenison-man — Can you post the ODD source to the snippet above? Is it an <egXML> child of a <elementSpec> (or similar), or inside a paragraph or some such? Thanks.

sydb commented 2 years ago

Tests so far:

I must admit, I find that combination somewhat confusing. In any case, where it says PROBLEM I found the same ugly indentation @ddenison-man reports in <egXML> when a child of <p> in the prose or in schemaSpec/elementSpec/exemplum.

@ddenison-man — you can ignore my query, above. This ticket will probably be assigned this coming Wed 01 Jun.

ddenison-man commented 2 years ago

It's just as a child of

following a

in the discursive part of the schema, but it makes no difference whether the example is moved inside

or not:

              <p>For direct literary or biblical quotations, the closing tag of the &lt;quote&gt; element is followed directly (without a space) by a &lt;bibl&gt; (bibliographic citation) element, with &lt;quote&gt; + &lt;bibl&gt; together wrapped in a &lt;cit&gt; (citation) element:</p>
<lb/>[...] <seg type="rp">that beautiful line of <persName ref="psn:tbc">Pope</persName>, where he describes <lb/>the Indian who <cit><quote>“sees God in Clouds and hears him <lb/>in the wind”</quote><bibl>Alexander Pope, <hi rend="italic">An Essay on Man, Epistle I</hi>.</bibl></cit></seg>

DD

<><><><><><><><><><><><><><><><><><><><><><><><><> Professor David Denison, FBA Professor Emeritus of English Linguistics School of Arts, Languages and Cultures University of Manchester | Manchester M13 9PL | U.K. https://www.research.manchester.ac.uk/portal/david.denison.html


From: Syd Bauman @.***> Sent: 30 May 2022 10:54 To: TEIC/Stylesheets Cc: David Denison; Mention Subject: Re: [TEIC/Stylesheets] in ODD to XHTML (Issue #553)

@ddenison-manhttps://github.com/ddenison-man — Can you post the ODD source to the snippet above? Is it an child of a (or similar), or inside a paragraph or some such? Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/TEIC/Stylesheets/issues/553#issuecomment-1140950237, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBCT566JJW2EXNMBJ5V473VMSF6LANCNFSM5XJY74GA. You are receiving this because you were mentioned.Message ID: @.***>

sydb commented 2 years ago

I.e., the following, right?

<p>For direct literary or biblical quotations, the closing tag of the <gi>quote</gi> element is followed directly (without a space)
  by a <gi>bibl</gi> (bibliographic citation) element, with <gi>quote</gi> + <gi>bibl</gi> together wrapped in a <gi>cit</gi>
  (citation) element:</p>

<egXML xmlns="http://www.tei-c.org/ns/Examples"><lb/>[...] <seg type="rp">that beautiful line of <persName ref="psn:tbc">Pope</persName>, where he describes
<lb/>the Indian who <cit><quote>“sees God in Clouds and hears him
<lb/>in the wind”</quote><bibl>Alexander Pope, <hi rend="italic">An Essay on Man,
Epistle I</hi>.</bibl></cit></seg></egXML>

I have created a tiny ODD file for testing this. Note that I have appended a “.txt” extension so that GitHub will not think it a malicious file.

ddenison-man commented 2 years ago

Dear Syd (if I may),

Your test file exhibits exactly the same behaviour as my long schema, giving the ugly indents from l.2 onwards with the latest stylesheets, but displaying fine with the previous stylesheets.

I apologise for giving the ODD source of a different snippet, an earlier selection that was messier than the one I sent screenshots of to this list. As far as I can see, you've got the code right.

Thanks for the speedy response.

best David

--

<><><><><><><><><><><><><><><><><><><><><><><><><> Professor David Denison, FBA Professor Emeritus of English Linguistics School of Arts, Languages and Cultures University of Manchester | Manchester M13 9PL | U.K. https://www.research.manchester.ac.uk/portal/david.denison.html


From: Syd Bauman @.***> Sent: 30 May 2022 20:41 To: TEIC/Stylesheets Cc: David Denison; Mention Subject: Re: [TEIC/Stylesheets] in ODD to XHTML (Issue #553)

I.e., the following, right?

For direct literary or biblical quotations, the closing tag of the quote element is followed directly (without a space) by a bibl (bibliographic citation) element, with quote + bibl together wrapped in a cit (citation) element:

[...] that beautiful line of Pope, where he describes the Indian who “sees God in Clouds and hears him in the wind”Alexander Pope, An Essay on Man, Epistle I.

I have created a tiny ODD filehttps://github.com/TEIC/Stylesheets/files/8800520/DDT.odd.txt for testing this. Note that I have appended a “.txt” extension so that GitHub will not think it a malicious file.

— Reply to this email directly, view it on GitHubhttps://github.com/TEIC/Stylesheets/issues/553#issuecomment-1141439070, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBCT56PKY63CAL3NETZZM3VMUKXJANCNFSM5XJY74GA. You are receiving this because you were mentioned.Message ID: @.***>

sydb commented 2 years ago

No worries! I hope we can fix this before the next release, it is really quite ugly.

sydb commented 2 years ago

@bleekere and I assigned this to @sabineseifert (and @peterstadler:-) for the task of finding out what changed in the code between last release and now that caused this problem.

peterstadler commented 1 year ago

Just did some debugging and it seems to me the root cause (i.e. the major change from v7.52.0 to v7.53.0) is the changed HTML output serialization. If I remember correctly, we decided to align html5 and html outputs (setting html5 as default) and in this course various xsl:output elements have been updated, including the addition of indent="yes", see e.g. 89f1a9d.

@HelenaSabel I don't know whether the introduction of the @indent attribute was simply to beautify the output? If so, we could simply remove it (the indent="yes" attribute) again (or explicitly set it to "no") to fix the issue at hand.

HelenaSabel commented 1 year ago

Yes, the introduction of @indent was just aesthetic.
I think setting the attribute @indent to "no" is a more robust approach (in case there are some default serialization behaviors).

peterstadler commented 1 year ago

I will send in a PR asap