search

TEIC / Stylesheets

TEI XSL Stylesheets
228 stars 124 forks source link

Only check untyped descs or gloss for out of date translations #622

Closed raffazizzi closed 9 months ago

raffazizzi commented 10 months ago

In support of https://github.com/TEIC/TEI/pull/2473

joeytakeda commented 9 months ago

I think this has now been handled in https://github.com/TEIC/Stylesheets/issues/635 (PR: https://github.com/TEIC/Stylesheets/pull/636), more or less equivalently: where this PR adds an additional predicate—[not(@type)]—that checks just looks for any untyped desc, the current version of functions.xsl now specifies excluding deprecationInfo: [@xml:lang='en' and not( @type eq 'deprecationInfo' )]

So I think we can just close this without merging unless we'd prefer the more defensive not(@type)

raffazizzi commented 9 months ago

Yeah @joeytakeda I think we attacked this same problem from different angles. I'm pretty sure this is no longer needed.

sydb commented 9 months ago

Ah! Here it is; you found it, @joeytakeda. If I could have found this the other day I would have just merged this PR, rather than creating #635 & #636. I am undecided on whether not(@type) is better than what we have (not( @type eq 'deprecationInfo')), but think we should close this for now, either way. (And apparently @raffazizzi agrees, as he closed this while I was typing! :-)