search

TEIC / TEI

The Text Encoding Initiative Guidelines
https://www.tei-c.org
Other
270 stars 88 forks source link

tidy up detestable detest #2268

Closed sydb closed 2 years ago

sydb commented 2 years ago

Address issue #2267 in 2 separate commits as 2 separate steps in case folks like most of the ideas therein but do not want to see the detest.log file divided into 3 output log files.

Note

I do not think this PR requires two separate reviewers.

If one of the 2 requested reviewers okays it, then one of the 3 assignees needs to EITHER a) review it with an eye towards the upcoming release — will this make upcoming release that much easier (because this part of the build is less confusing) or harder (because something is different), and merge if the former; OR b) deliberately punt it to next release as too difficult to review now.

sydb commented 2 years ago

OK. Took another crack at this. My apologies, but it turns out to be a pain to test, because when tested on my local system of course the paths match, so if you fail to delete them properly the result is the same!

JanelleJenstad commented 2 years ago

Bump @HelenaSabel or @martindholmes. Martin pointed out a typo in his review. We need one of you to okay the merge.

sydb commented 2 years ago
  1. Typo @martindholmes spotted fixed in 48c7996.
  2. It was just in an informative message, anyway. I.e., only those who build the GLs would ever have seen it.
martindholmes commented 2 years ago

Tests pass and in my checking they run faster than before. Nice work!

sydb commented 2 years ago

BTW, assignees, the thing you want to look at is the Makefile. No point in really paying attention to the log files, I don’t think. And you should not feel compelled (although you should feel free) to scrutinize every line of code. The main test is does it work when you use it to test the GLs. The basic change is instead of validating in 3 different ways[1] generating one big log file, and then comparing it to expected, we now validate the same 3 different ways, but generate 3 separate log files (with semi-intelligent names) and compare each of them to expected individually. (This way, when there is a problem, you know which validation process it was in.) Also improved the messages you get as this happens so it is (a little) less confusing.

[1]

  1. validate detest.odd against p5odds.rng and p5odds.isosch (actually p5odds.message.isosch.xsl)
  2. validate detest.xml against detest.rnc
  3. validate detest.xml against detest.isosch (actually detest.xsl)