search

TEIC / TEI

The Text Encoding Initiative Guidelines
https://www.tei-c.org
Other
270 stars 88 forks source link

rewrite constraint "only_1_ODD_source" #2287

Closed peterstadler closed 1 year ago

peterstadler commented 2 years ago

This is a simple rewrite of the original constraint. It avoids to match the @source attribute and rather match the parent element; this is to avoid those pesky schematron warnings "SXWN9000: The child axis starting at an attribute node will never select anything" when Schematron contexts are matching attributes.

sydb commented 2 years ago

Seems fine (see review). But why is it necessary? The occurrence of that message clearly indicates a bug in your Schematron processor, not in the schema. And I had thought we no longer had that bug in our build process. Do we?

peterstadler commented 2 years ago

Not sure why Mr. Travis can’t find docker image, but I do not think it has anything to do with this PR, and would not worry about it.

Yes, I think GitHub had some issues yesterday. Will try to rerun those tests …

peterstadler commented 2 years ago

@raffazizzi what do you think? Ready to merge?