search

TEIC / TEI

The Text Encoding Initiative Guidelines
https://www.tei-c.org
Other
269 stars 88 forks source link

Ab in ab issue #1856 #2352

Closed ebeshero closed 1 year ago

ebeshero commented 1 year ago

I added a couple of commits to improve the paragraph examples in CO today, and I believe that responds to all of Council's requests from August. Is this ready to merge to dev for the October release and close #1856 and #1929?

ebeshero commented 1 year ago

@sydb @hcayless I'm adding you as reviewers just to make sure all is well, as I kind of went ahead and opened the PR before you answered me in Slack. I am pretty sure we've made the prose and example revisions we discussed.

ebeshero commented 1 year ago

@JanelleJenstad @martinascholger I revised this to supply a short passage from Jane Eyre for the introductory example of a paragraph, mostly because we didn't have an example from the Bronte sisters in the Guidelines and because I thought the paragraph might be interesting (people who have read the novle might be surprised that this paragraph comes from there). Anyway, most importantly it's clearly a paragraph this time. As we're going into refrigeration this week, I hope we can review the changes in this branch and see if it's ready for the Guidelines release.

martinascholger commented 1 year ago

The <desc> is missing in macro.abContent. I'm not able to leave the comment directly in the code ...

ebeshero commented 1 year ago

@martinascholger Want to take a look through this now? I think we've made the requested changes...

hcayless commented 1 year ago

Think this is ready. Merging before freeze.