search

TEIC / TEI

The Text Encoding Initiative Guidelines
https://www.tei-c.org
Other
269 stars 88 forks source link

Added `@type` to `<calendar>` and added an example of `@type` to prose `#HD44` for #2396 #2406

Closed trishaoconnor closed 1 year ago

trishaoconnor commented 1 year ago

Added @type to <calendar> to specify between real or actual and fictional calendar as per the example currently listed in the prose description for <calendar> in the Header (#HD44'). Also added@typeto the '<calendar> example in the prose description in the Header #HD44 for #2396.

Needs to be reviewed by Council because this issue has not been discussed in detail prior to pushing this pull request. @jamescummings and @martindholmes any thoughts on adding @type to <calendar>?

sydb commented 1 year ago

While I do not remotely think all members of Council need weigh in, I do want at least one, preferably two, more positive reviews before merging. Thus pinging @jamescummings, @sabineseifert, and @martinascholger.

sydb commented 1 year ago

My instinct is “yes”, updating the prose to discuss it a little is a good idea. However, we can do that next week. The att.typed membership needs to be merged today or tomorrow. That said, how about

  A <gi>calendar</gi> element may also have a <att>type</att> (and
  <att>subtype</att>) attribute in order to categorize the calendar in
  any convenient way. In the following example, <att>type</att> is
  used to differentiate real calendar systems in actual use from those
  used in a fictional environment.

?

jamescummings commented 1 year ago

All looks good to me for the record.