TEIC / TEI

The Text Encoding Initiative Guidelines
https://www.tei-c.org
Other
276 stars 88 forks source link

Address #2426 — do not allow elements or classes inside a datatype #2443

Closed sydb closed 1 year ago

sydb commented 1 year ago

What I did:

Note that I used an @role of "warn" on the constraint itself, on the theory that we should provide a sort of deprecation period. Feel free to disagree. (Either way — no deprecation needed, remove "warn", or re-word warning to make it a real deprecation.)

sydb commented 1 year ago

The ticket suggests we add prose that says, essentially “Macros are for use in content models, not attr values”. I did not do so, because <macroRef> cannot occur inside <attDef>, anyway.

raffazizzi commented 1 year ago

Reviewed files and tested schematron constraint. It all looks good to me. Build checks should be fixed before merging.

sydb commented 1 year ago

The build check failures are “rnv: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by rnv)”, so I kinda doubt it has anything to do with this PR. How do we ask Mr. Jenkins to re-run the checks? (Do I just go in and change some whitespace somewhere? :-)

HelenaSabel commented 1 year ago

Everything looks great. Build failed because of #2455. Tests pass in my local machine so I think it’s safe to merge.