Closed trishaoconnor closed 8 months ago
I have checked this pull request and it all seems like we want it. Thanks!
Thank you @HelenaSabel for spotting these mistakes. My apologies for not recognising that the commit was added to this PR. That was an accident. I have clicked "commit suggestion" so the deprecation note now matches the examples.
@trishaoconnor: do you want to try to delete commit https://github.com/TEIC/TEI/commit/61247e54d5412e5f1a2e46adb76ef92879c66b3a? I think you could try:
git revert --strategy resolve 61247e54d5412e5f1a2e46adb76ef92879c66b3a
That will delete the commit (without altering the history). But if @sydb, who is assigned to this PR, thinks it’s ok to merge it as it is, fine with me :)
Yes, the global addition of mode="add"
was added to this PR by mistake. But since it is a separate commit, and has no effect on anything anyway, I would just not worry about it. (Except to avoid a “squash and merge”.)
But that may just be me being lazy — feel free to separate to a separate PR if y’all think it important.
An attempt to ping @GusRiva on the TEI repo. Please ignore.
Deprecated the
<re>
element for #2487 and in examples replaced<re>
with<entry>
element with the@type
set to "relatedEntry".