TEN-framework / ten_framework

TEN, the Next-Gen AI-Agent Framework, the world's first truly real-time multimodal AI agent framework.
https://doc.theten.ai/
Other
285 stars 22 forks source link

[BUG] No error for conflict extensions in manifest.json. #217

Open tomasliu-agora opened 18 hours ago

tomasliu-agora commented 18 hours ago

Description

{ "type": "extension", "name": "agora_rtc", "version": "=0.8.0-rc2" }, { "type": "extension", "name": "agora_rtm", "version": "0.1.2" }

two extensions require different runtime (0.2 and 0.3)

when run tman install or make build, no error is displayed and no change on the workspace.

tomas@WAGIT03652:~/CodeBase/github/czhen_TEN/agents$ tman install πŸ” Resolving packages... πŸ’‘ The following local packages do not appear in the dependency tree: extension:file_chunker@0.4.0 extension:llama_index_chat_engine@0.4.0 extension:chat_transcriber_python@0.4.0 system:ten_runtime_python@0.2.0 extension:message_collector@0.1.0 extension:azure_tts@0.4.2 extension:tsdb_firestore@0.1.0 extension:elevenlabs_tts_python@0.4.0 extension:http_server_python@0.5.0 extension:openai_chatgpt@0.4.0 extension:polly_tts@0.4.0 extension:transcribe_asr_python@0.4.0 extension:gemini_llm_python@0.4.0 extension_group:default_extension_group@0.2.0 extension:interrupt_detector_python@0.4.0 extension:aliyun_text_embedding@0.4.0 system:azure_speech_sdk@1.38.0 extension:aliyun_analyticdb_vector_storage@0.4.0 extension:agora_rtc@0.7.0-rc2 extension:bedrock_llm_python@0.4.0 extension:weatherapi_tool_python@0.1.0 extension:py_init_extension_cpp@0.2.0 system:ten_runtime@0.2.0 system:agora_rtc_sdk@4.1.36+build331418 extension:bingsearch_tool_python@0.1.0 extension:interrupt_detector@0.4.0 extension:fish_audio_tts@0.4.0 system:nlohmann_json@3.11.2 extension:elevenlabs_tts@0.4.0 extension:openai_chatgpt_python@0.1.0 extension:fashionai@0.1.0 extension:qwen_llm_python@0.4.0 system:ten_runtime_go@0.2.0 extension:openai_v2v_python@0.1.0 extension:cosy_tts@0.4.0 πŸ“¦ Installing packages... [00:00:00] [########################################] 0/0 Done πŸ† Install successfully in 18 seconds

Environment

windows wsl ubuntu 22.04

Steps to reproduce

{ "type": "extension", "name": "agora_rtc", "version": "=0.8.0-rc2" }, { "type": "extension", "name": "agora_rtm", "version": "0.1.2" }

two extensions require different runtime (0.2 and 0.3)

Expected behavior

report error and fail on the execution

Actual behavior

no error reported

Version

tman 0.3.0

Severity

Major

Additional Information

No response

tomasliu-agora commented 7 hours ago

attach whole manifest.json if needed. { "type": "app", "name": "ten_agent", "version": "0.4.0", "dependencies": [ { "type": "system", "name": "ten_runtime_go", "version": "0.3" }, { "type": "extension", "name": "py_init_extension_cpp", "version": "0.3" }, { "type": "extension", "name": "agora_rtc", "version": "=0.8.0-rc2" }, { "type": "extension", "name": "agora_rtm", "version": "0.1.2" }, { "type": "system", "name": "azure_speech_sdk", "version": "1.38.0" }, { "type": "extension", "name": "azure_tts", "version": "=0.5.1" } ] }

leoadonia commented 6 hours ago

tman resolves the package candidates based on the semantic version syntax.

The agora_rtm extension declared in manifest.json is:

{
  "type": "extension",
  "name": "agora_rtm",
  "version": "0.1.2"
}

The version 0.1.2 means the candidates in the range [0.1.2, 0.2.0), and the highest version will be resolved if there is no conflict dependencies.

Extension agora_rtm has a version 0.1.3, which depends on ten_runtime with version 0.3:

{
  "type": "system",
  "name": "ten_runtime",
  "version": "0.3"
}

So, after tman install, the following packages will be resolved:

The behavior is as expected.

leoadonia commented 6 hours ago

However, if we change the extension agora_rtm in the manifest.json to =0.1.2, which means only the version 0.1.2 is wanted.

Then, after tman install, the output will be as follows:

πŸ”  Resolving packages...
πŸ”’  Creating manifest-lock.json...
πŸ“¦  Installing packages...
  [00:00:00] [########################################]       0/0       Done                                                                                                                                                                            πŸ†  Install successfully in 27 seconds

No package is resolved.

To be fixed.