search

TEOS-10 / GSW-Python

Python implementation of TEOS-10 GSW based on ufunc wrappers of GSW-C
https://teos-10.github.io/GSW-Python
Other
143 stars 30 forks source link

Closes 74 #126

Closed ocefpaf closed 1 year ago

ocefpaf commented 1 year ago

Added a test to avoid regressions and pinned pandas to >=2 in our tests. Note that pandas is not a direct dependency of gsw so in a way that bug is only fixed if the user updates their pandas.

I also moved all the metadata from setup.cfg to pyproject.toml to help consolidate the packaging with less files and a more modern approach. I'll try to do the same for the setup.py in a future PR. but compiled extensions are still hard to do in a consistent manner.

PS: I'll fix the lints in another PR this one is already too big for its own sake.

efiring commented 1 year ago

It looks like ruff is finding some legacy things that could be cleaned up (but that don't hurt, so they are very low priority), and some things we probably don't want to change at all. Maybe the thing to do is to turn ruff off for now, so the rest of this changeset can be merged without leaving behind perpetual test failure.

ocefpaf commented 1 year ago

without leaving behind perpetual test failure.

I'm planning on working on this as soon as this one is merged. I already have the changes locally, from fixes to file/test skips. Hopefully the failure won't be there for more than a day. But I can turn it off, merge and on again, no problem.

ocefpaf commented 1 year ago

Fine to go ahead with this as is.

I pushed them here in case you have some free cycles to look at them (last commit) of https://github.com/TEOS-10/GSW-Python/pull/127

ocefpaf commented 1 year ago

Follow up in #127. I don't want to make this PR too big and hard to follow.