search

TES5Edit / TES5Edit

xEdit by Elminster; Updated and maintained by Sharlikran, Zilav, and Hlp
Mozilla Public License 2.0
753 stars 141 forks source link

Using F2 to renumber forms breaks the TES4 header record. #799

Open Arthmoor opened 4 years ago

Arthmoor commented 4 years ago

yarrmateys on Discord discovered a nasty little bug.

If you take any mod, doesn't matter which one, open the file tree. Select the "File Header" record so the TES4 record is visible on the right. Hit F2. You'll be asked to enter a form ID to start renumbering from.

The input does not seem to be getting validated for one thing, it let me enter anything I wanted. What's worse though is that in doing so it changed the "FormID" value from the expected 00000000 to the number I gave to the prompt. This results in a file you can no longer save because this value should not be editable.

correct

broken

Arthmoor commented 4 years ago

This was done with 4.0.3 btw.

fireundubh commented 4 years ago

What arguments are you running xEdit with?

Arthmoor commented 4 years ago

Just the -IKnowWhatImDoing argument.

Even with that though, I see no reason that form renumbering should ever touch the TES4 header area outside of messing with ONAMs in games that support them.

fireundubh commented 4 years ago

Cannot reproduce in the dev-4.1.4 branch. Can you provide screenshots of your General and Experts settings?

Arthmoor commented 4 years ago

Am able to reproduce this on 4.1.3b which was just posted to the builds channel today.

General Settings: image

Expert Settings: image

fireundubh commented 4 years ago

Oh! F2 on the File Header in the tree. I was pressing F2 on the FormID in the Record Header. I will investigate this. Thanks.