search

TESSkyblivion / skyblivion-niflib

An enhanced version of Niflib, reworked for skyblivion's needs
GNU General Public License v3.0
26 stars 18 forks source link

Broken and undocumented git submodules #9

Open theCalcaholic opened 5 years ago

theCalcaholic commented 5 years ago

I did the developer "test" from your application form yesterday and just wanted to give you a heads-up, that one of your git submodules (lib/libigl) can't be cloned/pulled at the moment, because it's maintainer changed its git history and thus invalidated the commit rev.

Also, since you're using this repository as a test, I think it might be a good idea to document in the Readme that the repository should be checked out with git clone --recurse-submodules assuming that familiarity with git submodules is not one of the core skills that you want to test. :wink:

I, for instance, didn't check for submodules until I stumbled across missing file errors in cmake

TAImatem commented 5 years ago

also, v-hacd's cmake files may give you problems, as a quick dirty fix just change v-hacd's paths as if ${CMAKE_SOURCE_DIR} is niflib's root directory PS no, the problem wasn't in "pthread"

pseigo commented 4 years ago

Or, if you've already cloned you can run git submodule update --init. :)