TESTgroup-BNL / NGSapFlux_r

An R package for working with and processing sap flux generated using the BNL TEST group NGSapFlux sensor package
GNU General Public License v3.0
0 stars 0 forks source link

sanity_check_* should allow for user selectable pre and post periods #3

Open serbinsh opened 1 year ago

serbinsh commented 1 year ago
sanity_check_fine <- function(df, Dates=unique(df$Date), 
                              Pre_Threshold_Temp_Upper=0.2, 
                              Pre_Threshold_Temp_Lower=0.2,
                              Post_Threshold_Temp_Upper=5, 
                              Post_Threshold_Temp_Lower=0.2) {}

We could easily add two params that define the time period we consider pre-pulse and post-pulse. Currently defaults are

pre-pulse(00:00-02:00) post-pulse (02:01-15:00)

serbinsh commented 1 year ago

Aslo we need to improve what the outputs are, why they are formatted as they are, and the expected usage of the returned data from the function with examples. at the moment its not clear to me what the three outputs are needed for vs a QAQC dataset we can use for the next step