search

TF2-DMB / CBaseNPC

Provides a friendly interface for plugins to use in order to create custom NPCs on the game Team Fortress 2
36 stars 5 forks source link

Extension broken as of SM 1.12 revision 6998 #38

Closed Kenzzer closed 1 year ago

Kenzzer commented 1 year ago

alliedmodders/sourcemod#1908 Has broken the method by which we cleared datamap cache, building and loading the ext against newer versions of sourcemod will most certainly memory corrupt everything if not outright crash.

Fortunately there's a PR that is going to address that. However it won't be exposed to extensions right away which sucks, the gamehelpers interface must be updated... So this PR is pretty much useless on its own alliedmodders/sourcemod#1943

In the meanwhile, I suggest we continue our hacking into CHalfLife2 as before https://github.com/TF2-DMB/CBaseNPC/blob/09ea2e4d5aecc772ff6abd11abfaa3de149ea1b3/extension/idatamapcontainer.cpp#L831L841 However, since we're maintaining compatibility with sm 1.11. This means we have to split to build pipeline, and begin to make release against sm 1.11 and 1.12 respectively.

sirdigbot commented 1 year ago

Updated https://github.com/alliedmodders/sourcemod/pull/1943 to accommodate this.

Kenzzer commented 1 year ago

Thank you for the changes !