search

TFNS / CTFNote

CTFNote is a collaborative tool aiming to help CTF teams to organise their work.
GNU General Public License v3.0
505 stars 56 forks source link

Fix build errors observed with Bun #233

Open erdnaxe opened 4 months ago

erdnaxe commented 4 months ago

This pull requests proposes to fix multiple errors raised during a Bun build of CTFNote front. I believe most of these errors are due to an apollo version bump as bun is not using yarn.lock.

Definitely need an extra pair of eyes to check what I propose in https://github.com/TFNS/CTFNote/pull/233/commits/e07b82cea9f82dbf623353a8136f45cbda0811b7, I might have broken something.

JJ-8 commented 4 months ago

Downstream I don't have any problems with building since the image I just published was created just fine: https://github.com/JJ-8/CTFNote/actions/runs/8020464483/job/21910366732 Maybe it is related to this commit that I don't have any issues: https://github.com/JJ-8/CTFNote/commit/f1f070c3014cab7dfbe0c3a26b7f8f3082801459 which freezes all the dependencies and add them to git to make CTFNote 'live forever'.

JJ-8 commented 2 months ago

Hi @erdnaxe, can you try to use v3.0.0 and see if the problem still persist? If so, can you have a look at this again?

Commit https://github.com/TFNS/CTFNote/pull/233/commits/e07b82cea9f82dbf623353a8136f45cbda0811b7 should be merged anyway since it fixes an important deprecation notice.

erdnaxe commented 2 weeks ago

Dropped two commits that are no longer needed with v3.0.0 (thanks!). I rebased and linted the fix for the deprecation.

Quasar is still failing to build with bun, but now it is because of quasar using something not yet implemented in bun (not a problem on our side anymore).