search

TFNS / CTFNote

CTFNote is a collaborative tool aiming to help CTF teams to organise their work.
GNU General Public License v3.0
520 stars 61 forks source link

API: honour DB_HOST and DB_PORT #235

Closed XeR closed 5 months ago

XeR commented 6 months ago

API needs to wait for the database to be up before starting.

We do not know how long it takes: just because the container is started doesn't mean that Postgres is ready. The workaround is to use a small script (start.sh) that waits until a connection to the database can be done before passing the execution to yarn.

The Dockerfile contains hardcoded values for the database's hostname and ports, but there is no guarantee that these values are always the same. This is especially true when trying to deploy CTFNote with a previously-existing database.

This commit removes the hardcoded values and replaces them with DB_HOST/DB_PORT.

Closes #234 Related to #200

JJ-8 commented 5 months ago

This is already included in https://github.com/TFNS/CTFNote/pull/237