search

TGAC / brassica

Brassica Information Portal
GNU General Public License v3.0
6 stars 4 forks source link

Unknown population type for population BraVCS3M_01 #115

Closed nowakowski closed 9 years ago

nowakowski commented 9 years ago

The population type for population BraVCS3M_01 is undefined. This is the only such record in plant_populations. Could you suggest an appropriate pop_type_lookup record to attach to this population?

wjurkowski commented 9 years ago

There is no 'unspecified' type present in pop_type_lookup mysql> select distinct population_type from pop_type_lookup: +-----------------------------+ | population_type | +-----------------------------+ | Azacytidine epi-mutated | | Back Cross | | DH segregating | | Diversity core collection | | Diversity fixed foundation | | Diversity foundation | | EMS mutated | | Experimental collection | | F1 hybrid | | F2 | | F3 | | F3 pooled | | Gamma irradiated | | Genetic resource collection | | Imortalized F2 | | Integrated | | Near isogenic | | Recombinant inbred | | Substitution lines | | Variety resource collection | +-----------------------------+

Maybe we could create such a type? and link it to all empty in _populationtype

+-----------------------------+ | unspecified | | not applicable | | none

2015-04-03 14:04 GMT+01:00 Piotr Nowakowski notifications@github.com:

Assigned #115 https://github.com/eSpectrum-IT/brassica/issues/115 to @wjurkowski https://github.com/wjurkowski.

— Reply to this email directly or view it on GitHub https://github.com/eSpectrum-IT/brassica/issues/115#event-272650342.

nowakowski commented 9 years ago

Indeed, the unspecified record was one of those dummy records we ended up removing (these included unspecified, unknown and not applicable). Rather than polluting pop_type_lookup with such records I would propose making this relation optional, i.e. enabling NULL values in plant_populations.population_type. How about it?

wjurkowski commented 9 years ago

OK

2015-04-05 17:28 GMT+01:00 Piotr Nowakowski notifications@github.com:

Indeed, the unspecified record was one of those dummy records we ended up removing (these included unspecified, unknown and not applicable. Rather than polluting pop_type_lookup with such records I would propose making this relation optional, i.e. enabling NULL values in plant_populations.population_type. How about it?

— Reply to this email directly or view it on GitHub https://github.com/eSpectrum-IT/brassica/issues/115#issuecomment-89801466 .

Nuanda commented 9 years ago

For the future - should BIP allow users make no assignment to population type or should it require users to choose a population type (as it does now) so all future records have that relation defined?

wjurkowski commented 9 years ago

Yes it could be part of QC to require that vital record like that are completed

2015-04-07 9:32 GMT+01:00 Tomasz Gubała notifications@github.com:

For the future - should BIP allow users make no assignment to population type or should it require users to choose a population type (as it does now) so all future records have that relation defined?

— Reply to this email directly or view it on GitHub https://github.com/eSpectrum-IT/brassica/issues/115#issuecomment-90461583 .

nowakowski commented 9 years ago

Nothing to be done - closing issue.