search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.76k stars 429 forks source link

More comprehensive scrutinizer config. #571

Closed jrfnl closed 8 years ago

jrfnl commented 8 years ago

Prevents builds in forks throwing different results (Scutinizer uses a config cascading merge).

Includes minor code changes based on Scrutinizer feedback. Also reset the Scrutinizer filtered issues and only re-filtered persistent issues we can't currently get rid off for varying reasons.

GaryJones commented 8 years ago

Probably should have been separate commits - the config file is fine to merge, but one small query on one of the fixes means the PR can't be merged immediately.

jrfnl commented 8 years ago

See my above comment - exactly the reason why I put in one PR (though I can easily make it two commits of course).

GaryJones commented 8 years ago

Are you planning to change these hook names back or not?

jrfnl commented 8 years ago

Yes I am, just need to figure out the scrutinizer rule to invert.

jrfnl commented 8 years ago

Adjusted & turned into two separate commits, one for the config, one for the code adjustments.

The issue is triggered by the WPCS rules, so no specific Scrutinizer rule I can disable for that. In the WPCS config the severity is 0, but clearly Scrutinizer cannot deal with this properly, so ended up filtering out the issue in Scrutinizer itself.

jrfnl commented 8 years ago

Hang on - some alignment issues were introduced by the translators comments, let me fix those too.

jrfnl commented 8 years ago

Ok, all done.