search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.76k stars 430 forks source link

Update class-tgm-plugin-activation.php #595

Closed Vishal-Deshpande closed 8 years ago

Vishal-Deshpande commented 8 years ago

' __ ' Replaced with 'esc_html__( '

jrfnl commented 8 years ago

Closing as duplicate of #541 for the same reason.

Thank you for your pull request. Unfortunately your PR would result in most strings being double escaped.

Escaping should be done late, i.e. at the point the string is send to the screen, not earlier. If you'll look at those instances, you'll see that strings are being escaped.

Please feel free to refresh this PR (or send in a new one) if it would turn out that we missed a few.