search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.76k stars 430 forks source link

Text domain doesn't update instances of tgmpa in download bundle #600

Closed martinburdon closed 8 years ago

martinburdon commented 8 years ago

When setting a text domain for a custom download of TGMPA the text domain inside the bundled file remains as 'tgmpa'.

GaryJones commented 8 years ago

Did you have the generator set to Theme, Child Theme or Plugin?

If applicable, did you have WordPress.org, Theme Forest, or Other as the distribution platform?

martinburdon commented 8 years ago

Hi Gary, I had it set to Theme and ThemeForest.

jrfnl commented 8 years ago

Hi @martinburdon, when we created the Generator this was discussed with a representative of ThemeForest and they indicated that the text-domain did not need to be changed for themes hosted on ThemeForest. The advantage of keeping the TGMPA text-domain is that your translators won't need to translate the TGMPA text strings and that you already have translations available for the TGMPA text strings in 17 languages (as of v 2.6.0),

For full details of the differences between the output based on the choices you can make in the form: https://github.com/TGMPA/TGM-Plugin-Activation/pull/519

martinburdon commented 8 years ago

Thanks for your response @jrfnl very informative :)

I'm sure I had a soft rejection before my theme got approved, asking me to keep all text domains within the theme to my themes slug, including TGMPA :/ I might push up an update to my theme reverting the text domain back to 'tgmpa' and see if it gets passed review.

Thanks for your time 👍

jrfnl commented 8 years ago

@martinburdon If the reviewers would comment on it, point them to @Stephen-Cronin who will put them right.

martinburdon commented 8 years ago

@jrfnl awesome stuff, thanks for the info :)

Stephen-Cronin commented 8 years ago

@martinburdon - Yep that should be fine. If you were to be soft rejected again for that reason, then when you're resubmitting, just add a note for the reviewer to check with me. Thanks!