Dismissable - Githubissues

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.

http://tgmpluginactivation.com/

GNU General Public License v2.0

1.76k stars 429 forks source link

Dismissable #608

Open kprovance opened 8 years ago

kprovance commented 8 years ago

I'm a little confused on how this should actually work. There seem to be two ways to dismiss a notice. With the link provided, and the small X as the top right. Using the link, the notice goes away until it's needed again. When using the small X, the notice goes away, but comes right back on page refresh. Is that by design?

When we added this feature for Redux, the notice says closed until it's updated or needed again.

jrfnl commented 8 years ago

@kprovance The TGMPA admin notice is buggy and has been for a while. We are aware and need to rethink the whole logic in combination with the various use cases of TGMPA. Unfortunately a bit more complex than it seems.

See: https://github.com/TGMPA/TGM-Plugin-Activation/issues?q=is%3Aopen+is%3Aissue+label%3A%22admin+notices%22

kprovance commented 8 years ago

Gotcha. Obviously, I don;t know the inner workings all that well, but does this also apply to the Dismiss link? That seems to work well? Could the same logic not be applied to the X? I'm going to have to see what we did with Redux...I don't rightly recall.

jrfnl commented 8 years ago

The dismiss link itself is just as buggy in the current TGMPA unfortunately.

The complexity (which is currently not being handled) is a build up of:

admin notice should be per user
should re-appear when there is an update available and that update will satisfy a minimum version requirement (but only for plugins which currently do not satisfy the minimum version set)
should re-appear if new dependencies are detected - i.e. either because of a switch of theme, an upgrade of the theme adding new dependencies, a plugin being installed also using TGMPA adding more dependencies, a plugin using TGMPA being updated etc.

To solve this we'd need to start 'remembering' (option/transient) which dependencies are known, which user has been notified, which user has dismissed the notice and such.

In the current planning this will be completely revised (and hopefully solved in a stable way) in TGMPA v3.