Closed cyberwani closed 7 years ago
Thanks @cyberwani.
Can you please show a screenshot with your change? Have you checked what happens with the border when the screen is narrow and lines wrap around? Is the red the same hex code of the attention grabbing red in WP core? (For which there's a Trac ticket open by @afercia) to consolidate these down).
You'll need to ensure you meet code standards - see https://travis-ci.org/TGMPA/TGM-Plugin-Activation/jobs/159883749 for issues with your PR.
Here are some screenshots:
I used same color code used in WordPress warnings.
Thanks for providing those. Visually, I'm OK with that. @jrfnl ?
@cyberwani The code will still need fixing for code standards.
Visually I like the change, nice one!
Code-wise, quite apart from the code style issues, I'd like to properly review it before merging and it may be a little while before I have the time.
@GaryJones @jrfnl I am not familiar with Travis. So, can you both suggest me the further steps?
Travis is an automated code check which runs on the code and causing one of the red crosses below. If you click on "Details", you can see which checks are run and which is failing. In this case it is failing as the code does not comply with the WordPress coding standards. For details of what you need to fix, click on the failing build to see the feedback given there: https://travis-ci.org/TGMPA/TGM-Plugin-Activation/jobs/159883749#L202
For reference, the following code standards (formatting of the code) need to be addressed:
----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
2099 | ERROR | [ ] Missing function doc comment
| | (Squiz.Commenting.FunctionComment.Missing)
2754 | ERROR | [x] Concat operator must be surrounded by a single
| | space
| | (Squiz.Strings.ConcatenationSpacing.PaddingFound)
2754 | ERROR | [ ] Expected next thing to be an escaping function (see
| | Codex for 'Data Validation'), not 'strtolower'
| | (WordPress.XSS.EscapeOutput.OutputNotEscaped)
2754 | ERROR | [x] Expected 1 spaces after opening bracket; 0 found
| | (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket)
2754 | ERROR | [x] Expected 1 spaces before closing bracket; 0 found
| | (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket)
2754 | ERROR | [x] Concat operator must be surrounded by a single
| | space
| | (Squiz.Strings.ConcatenationSpacing.PaddingFound)
----------------------------------------------------------------------
So, for the indicated lines:
.
.esc_attr()
call around the strtolower()
call.
4, 5 and 6. Add extra spaces as indicated.
added left-border in plugin list for required plugins.