search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.76k stars 429 forks source link

Update admin notices not visible #646

Closed danyj closed 7 years ago

danyj commented 7 years ago

Just changed required plugin version to test and the only notice I see is in plugin itself. Admin notices do not appear. Cleared cache tried different browser

screenshot_23

tgmpa plugin array

    array(
        'name'               => 'Assign Widgets', // The plugin name.
        'slug'               => 'assign-widgets', // The plugin slug (typically the folder name).
        'source'             => 'https://github.com/Themezly/Assign-Widgets/archive/master.zip', // The plugin source.
        'required'           => true, // If false, the plugin is only 'recommended' instead of required.
        'version'            => '1.0.3', // E.g. 1.0.0. If set, the active plugin must be this version or higher.
        'force_activation'   => false, // If true, plugin is activated upon theme activation and cannot be deactivated until theme switch.
        'force_deactivation' => true, // If true, plugin is deactivated upon theme switch, useful for theme-specific plugins.
    ),
jrfnl commented 7 years ago

Could it be that you dismissed the TGMPA notice before ?

danyj commented 7 years ago

I disabled the theme , reactivated and notice showed , so seems like I did dismiss it . not sure if notices are in DB or cache , if DB than it would make sense not to see it in another browser , if cache than it makes no sense. but I think it is related to https://github.com/TGMPA/TGM-Plugin-Activation/issues/353

jrfnl commented 7 years ago

@danyj It's being saved in the database, so yes, #353 is the issue which is open about this.

danyj commented 7 years ago

ok , il close this than until other one is fixed