Incorrect type of source determination

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.

http://tgmpluginactivation.com/

GNU General Public License v2.0

1.76k stars 429 forks source link

Incorrect type of source determination #664

Closed pasqualevitiello closed 7 years ago

pasqualevitiello commented 7 years ago

Hey guys,

get_template_directory_uri makes External Source display, while it should say Pre-Packaged.

Cheers!

screen-shot-2017-05-26-at-10 20 24

jrfnl commented 7 years ago

No, for pre-packaged plugins you should use get_template_directory() as TGMPA expects a path. If it is given a URL it will download the file instead of directly accessing it through the file system, which is why it is considered an external source.