search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.76k stars 429 forks source link

Change behaviour if ABSPATH not found #665

Closed GaryJones closed 7 years ago

GaryJones commented 7 years ago

exit-ing kills command line scripts (like phpunit or phpcs) completely (and silently, grrrr), instead of just ignoring the rest of the TGMPA file, which is what return does.

See #594.

Aside: I'd really like to see this go out as a hotfix, even if some of the other developments since the last release are not ready.

jrfnl commented 7 years ago

I'd really like to see this go out as a hotfix, even if some of the other developments since the last release are not ready.

The change which added the codesnippet to TGMPA is not (yet) contained in a release, so why should this be a hotfix ?

GaryJones commented 7 years ago

The change which added the codesnippet to TGMPA is not (yet) contained in a release, so why should this be a hotfix ?

Because the problem that the original snippet was attempting to solve, is still a problem in the wild (i.e. for a project I've got!)

GaryJones commented 7 years ago

@jrfnl Any thoughts on the Travis failures?

jrfnl commented 7 years ago

@jrfnl Any thoughts on the Travis failures?

Travis failures have to do with the release of PHPCS 3.x and WPCS not (yet) being compatible. We may need to make some minor code style fixes as well considering all the new checks in WPCS since the last merge.

GaryJones commented 7 years ago

Travis failures have to do with the release of PHPCS 3.x

I thought you'd already limited Travis to the 2.9.* branch of PHPCS?

jrfnl commented 7 years ago

I thought you'd already limited Travis to the 2.9.* branch of PHPCS?

Doesn't look like I did: https://github.com/TGMPA/TGM-Plugin-Activation/blob/develop/.travis.yml

I did update the code for the WPCS 0.11.0 release, but that was before PHPCS 3.x came out.