Closed GaryJones closed 7 years ago
I'd really like to see this go out as a hotfix, even if some of the other developments since the last release are not ready.
The change which added the codesnippet to TGMPA is not (yet) contained in a release, so why should this be a hotfix ?
The change which added the codesnippet to TGMPA is not (yet) contained in a release, so why should this be a hotfix ?
Because the problem that the original snippet was attempting to solve, is still a problem in the wild (i.e. for a project I've got!)
@jrfnl Any thoughts on the Travis failures?
@jrfnl Any thoughts on the Travis failures?
Travis failures have to do with the release of PHPCS 3.x and WPCS not (yet) being compatible. We may need to make some minor code style fixes as well considering all the new checks in WPCS since the last merge.
Travis failures have to do with the release of PHPCS 3.x
I thought you'd already limited Travis to the 2.9.* branch of PHPCS?
I thought you'd already limited Travis to the 2.9.* branch of PHPCS?
Doesn't look like I did: https://github.com/TGMPA/TGM-Plugin-Activation/blob/develop/.travis.yml
I did update the code for the WPCS 0.11.0 release, but that was before PHPCS 3.x came out.
exit
-ing kills command line scripts (likephpunit
orphpcs
) completely (and silently, grrrr), instead of just ignoring the rest of the TGMPA file, which is whatreturn
does.See #594.
Aside: I'd really like to see this go out as a hotfix, even if some of the other developments since the last release are not ready.