Closed theemwiz closed 7 years ago
I am too facing the same issue. Can you please provide a fix for it?
Can you be more descriptive about the error message please?
Which plugin or theme is using TGMPA? What version of TGMPA is being used?
The TGMPA version which is used is 2.6.1. I am developing this theme.
I have tested it in 4 WordPress themes with TGM v2.6.1 and getting the same error as shown in screenshot above.
I have the same error. The problem appeared after the 4.8v wp.
Bingo! Issue solved. I added some changes in class-tgm-plugin-activation.php
Change:
$this->upgrader->strings['skin_update_successful'] = %HERE LONG DEFAULT CODE CALLED ERROR%
to
$this->upgrader->strings['skin_update_successful'] = __( '%1$s done.' );
@al5dy Can you attach the full code here?
@simrandeep Fix only one function. https://gist.github.com/al5dy/965d0eefffab32df3b04badbc2274d08
@al5dy
Thank you! It fixed the issue :)
@al5dy Thanks for the fix. Look forward to TGMPA official update.
Thanks all for the useful feedback - we'll look into this ASAP (as we'll also need to make it work with older versions of WP.
I have the same error and can not install requires plugin on PHP 5.3 // WP 4.8
A fix for this issue (#670) has now been merged in and will be included in the upcoming 2.6.2 release.
@jrfnl Any updates on the release?
Many thanks @al5dy. Your fix worked!
Is this still an issue in 4.9? I just did a clean install, installed Jupiter 6.1.1 and got the error on required plugins. Warning: sprintf(): Too few arguments in \wp-admin\includes\class-bulk-upgrader-skin.php on line 150
Had to fix with: Old Code: if ( $this->result && ! is_wp_error( $this->result ) ) { if ( ! $this->error ) { echo '
' . sprintf( $this->upgrader->strings['skin_update_successful'], $title ) . ' ' . '
New Code: if ( $this->result && ! is_wp_error( $this->result ) ) { if ( ! $this->error ) echo '
' . sprintf($this->upgrader->strings['skin_update_successful'], $title, 'jQuery(\'#progress-' . esc_js($this->upgrader->update_current) . '\').toggle();jQuery(\'span\', this).toggle(); return false;') . '
@MiGzY Ran into this issue as well, however, a solution I found (courtesy of ahmadhassan10) was to replace:
if ( ! $this->error ) {
echo '<div class="updated js-update-details" data-update-details="progress-' . esc_attr( $this->upgrader->update_current ) . '">' .
'<p>' . sprintf( $this->upgrader->strings['skin_update_successful'], $title ) .
' <button type="button" class="hide-if-no-js button-link js-update-details-toggle" aria-expanded="false">' . __( 'Show details.' ) . '</button>' .
'</p></div>';
}
echo '<script type="text/javascript">jQuery(\'.waiting-' . esc_js($this->upgrader->update_current) . '\').hide();</script>';
}
With This:
if ( ! $this->error )
echo '<div class="updated"><p>' . sprintf($this->upgrader->strings['skin_update_successful'], $title, 'jQuery(\'#progress-' . esc_js($this->upgrader->update_current) . '\').toggle();jQuery(\'span\', this).toggle(); return false;') . '</p></div>';
echo '<script type="text/javascript">jQuery(\'.waiting-' . esc_js($this->upgrader->update_current) . '\').hide();</script>';
}
Seems to work fine now.
Yes - that's a stripped down version of my code by the looks.
This is still happening! When do you release a new version? If I check on relases I see 2.6.1 is the latest.
Still there:
Warning: sprintf(): Too few arguments in D:\xampp\htdocs\main.wp\wp-admin\includes\class-bulk-upgrader-skin.php on line 152
I have the same issue
I am getting this warning Warning: sprintf(): Too few arguments when installing plugins through TGMPA script on WordPress 4.8. Is this a known warning with latest version of WordPress?