Ensure composer.lock stays out of version control

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.

http://tgmpluginactivation.com/

GNU General Public License v2.0

1.75k stars 431 forks source link

Ensure composer.lock stays out of version control #715

Closed GaryJones closed 6 years ago

GaryJones commented 6 years ago

This is a library package, not an application.

See https://blog.martinhujer.cz/17-tips-for-using-composer-efficiently/#tip-%236%3A-put-%60composer.lock%60-into-%60.gitignore%60-in-libraries

jrfnl commented 6 years ago

@GaryJones Tip 13 of the article looks like a great suggestion as well. Do you intend to pull that too ?

GaryJones commented 6 years ago

Wasn't intending to, but we can. We'd just need to get the SPDX identifier updated, depending on the version of Composer that our Travis setup is running.

jrfnl commented 6 years ago

@GaryJones I've just run some tests:

On Composer 1.5.0, using the newer license annotation will cause validation to fail.
On Composer 1.6.0+, using the old license annotation will cause validation to fail.

In both cases, it's only a warning, so validating with composer validate --no-check-all - note: without the --strict - exits without errors on both versions I tested.