search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.75k stars 431 forks source link

Add fr_CA copied from fr_FR + minor corrections. #730

Closed ghost closed 6 years ago

ghost commented 6 years ago

Our production use fr_CA, it was easy to add it by copying the existing fr_FR. I have added a few minor corrections that are not locale specific, so I have updated fr_FR too.

ps : TGMPA is great tool, helped streamline our installation process, thanks for that!

ghost commented 6 years ago

I have added another set of corrections instead of submitting another pull request. The second set of corrections could benefit from a review from other french users of TGM.

ghost commented 6 years ago

Sorry for the multiple submit. I'll wait for review before doing other changes.

ghost commented 6 years ago

I will check the filename.

I was maybe imprecise. I'm actually french native but from Quebec. The revision was done by our linguistic service at Bibliothèque et archives nationales du québec (http://www.banq.qc.ca/) so you can have a good assurance that it's high quality.

What I meant by french reviewer was more french from France as there could be different terminology choices (also ponctuation can differ).

I will double check the changes that I think could be worth discussing and otherwise you could let it pass as base fr_CA. If someone is available for fr_FR later, they could review our changes to see if it's worth merging back.

ghost commented 6 years ago

I have deleted my fork this morning, I forgot about my pull request sorry. I will try to recover following the procedure here : https://stackoverflow.com/questions/20977530/recover-a-commit-sent-as-a-pull-request-from-a-deleted-fork-on-github

ghost commented 6 years ago

I was able to recover the pull request following the procedure but I prefer to not break things further, I did a new pull request : https://github.com/TGMPA/TGM-Plugin-Activation/pull/734

You can close / decline this one.