search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.75k stars 431 forks source link

Add has_notices on plugin level #749

Open danyj opened 6 years ago

danyj commented 6 years ago

This PR sets the has_notice on plugin level so that we can disable the notices for recommended plugins if we need to. Fixes #748

Usage 

    'bbpress'=> array(
        'name'      => 'bbPress',
        'slug'      => 'bbpress',
        'required'  => false,
        'force_activation'   => false,
        'has_notices' => false // This plugin will not be visible in the TGMPA notice
    ),
jrfnl commented 6 years ago

@GaryJones As this adds a new feature - do you agree that if this is merged in, the next version will need to be called 2.7.0 (instead of 2.6.2) ?

danyj commented 6 years ago

@jrfnl on it , going trough suggested changes.

danyj commented 6 years ago

not sure why travis is failing

danyj commented 6 years ago

A sister-PR is needed f

where is that git ?

danyj commented 6 years ago

@jrfnl please check the travis , all those lines were there and are untouched. I simply pulled the git and changed 4 lines and they do not seem to be failing.

danyj commented 6 years ago

Checked travis , all the lines mentioned in both files were there before my PR.

danyj commented 6 years ago

finally :)

jrfnl commented 6 years ago

@danyj Thanks for all the changes. I'll try to have another look later today.

where is that git ?

Regarding the sister-PR, it is in this same repo, just on another (orphan) branch: https://github.com/TGMPA/TGM-Plugin-Activation/tree/gh-pages

danyj commented 6 years ago

All set. Submitted PR for it.

danyj commented 5 years ago

or only when required is false

good point , I think only when required is falsebecause required true should always show notice.

@GaryJones @jrfnl , let me know and I can make changes if you agree