TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.75k stars 431 forks source link

Activate single plugin returns true even though plugin hasn't been activated #784

Open hogash opened 4 years ago

hogash commented 4 years ago

Hey guys, i noticed in the activate_single_plugin function if a plugin requires update, this function will still return true even if the plugin hasn't been activated.

Shouldn't this function return false if the plugin hasn't been activated, due to any reason? I would suggest return false in the $this->does_plugin_require_update( $slug ) condition check.