search

TGMPA / TGM-Plugin-Activation

TGM Plugin Activation is a PHP library that allows you to easily require or recommend plugins for your WordPress themes (and plugins). It allows your users to install, update and even automatically activate plugins in singular or bulk fashion using native WordPress classes, functions and interfaces. You can reference bundled plugins, plugins from the WordPress Plugin Repository or even plugins hosted elsewhere on the internet.
http://tgmpluginactivation.com/
GNU General Public License v2.0
1.75k stars 431 forks source link

Too few arguments, still happening #799

Closed MethylBromide closed 3 years ago

MethylBromide commented 3 years ago

Warning: sprintf(): Too few arguments in …/class-bulk-upgrader-skin.php on line 152

Fix is described here: https://gist.github.com/al5dy/965d0eefffab32df3b04badbc2274d08

Please make the indicated code change on line 24 of class-tgm-plugin-activation.php -- the string skin_update_successful is used in a context where sprintf is called with one data argument, and the formatting string you are assigning currently has two placeholders.

RupW commented 3 years ago

This probably best as a pull request, if you can make one please?

jrfnl commented 3 years ago

This has already been fixed in the code here. There are a number of other things though which a release is waiting on, pull requests for those are very welcome.

jrfnl commented 3 years ago

Marking this as a duplicate of #669 which was fixed by #670.