Cleared TODO regarding segfaults and fixed re-publishing metadata behavior

TGSAI / mdio-cpp

C++, Cloud native, scalable storage engine for various types of energy data.

Apache License 2.0

6 stars 3 forks source link

Cleared TODO regarding segfaults and fixed re-publishing metadata behavior #71

Closed BrianMichell closed 3 months ago

BrianMichell commented 3 months ago

Resolves #46

Addressed errant memory access in Dataset CommitMetadata call.

Fixed Stack-Use-After-Return issue
Fixed Heap-Use-After-Free issue
Added tracking of changed metadata back so publish can be more efficient
Expanded test case coverage

BrianMichell commented 3 months ago

 How robust is our testing here?

~~It could always stand to be more robust. Currently we have testing for deleting local datasets and GCS datasets.~~ Testing here is actually quite robust. I got the PRs mixed up in my head here.

blasscoc commented 3 months ago

Test run LGTM