search

TGSAI / mdio-python

Cloud native, scalable storage engine for various types of energy data.
https://mdio.dev/
Apache License 2.0
37 stars 13 forks source link

Improved logging in autochannelwrap. #332

Closed markspec closed 10 months ago

markspec commented 11 months ago

Update the logging in autochannlewrap.

It now logs explaining when and why it is using type A. It also suggests corrective actions if the user expects it to ingest as type b (unwrapped).

Resolves issue #331.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5db90a6) 84.32% compared to head (a9cf805) 84.34%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #332 +/- ## ========================================== + Coverage 84.32% 84.34% +0.02% ========================================== Files 46 46 Lines 2194 2198 +4 Branches 305 305 ========================================== + Hits 1850 1854 +4 Misses 301 301 Partials 43 43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tasansal commented 10 months ago

@markspec I made some code style changes to make it more readable. All tests pass, but to ensure logic didn't break, can you double-check? It's ready to merge besides that.

markspec commented 10 months ago

@tasansal , looks good!