search

TGSAI / mdio-python

Cloud native, scalable storage engine for various types of energy data.
https://mdio.dev/
Apache License 2.0
35 stars 13 forks source link

AutoShotWrap grid override #338

Closed markspec closed 8 months ago

markspec commented 9 months ago

This allows ingestion with gun indexed by unwrapping shot_point for shot_lines.

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 92.63158% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.59%. Comparing base (c3ba558) to head (c5acee3). Report is 9 commits behind head on main.

Files Patch % Lines
src/mdio/segy/geometry.py 86.00% 4 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #338 +/- ## ========================================== + Coverage 85.30% 86.59% +1.28% ========================================== Files 46 48 +2 Lines 2219 2440 +221 Branches 306 353 +47 ========================================== + Hits 1893 2113 +220 + Misses 281 274 -7 - Partials 45 53 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tasansal commented 9 months ago

Hi @markspec, can we add at least 1 test for each configuration?

tasansal commented 9 months ago

Closes https://github.com/TGSAI/mdio-python/issues/336

markspec commented 8 months ago

@tasansal , please can you look at this?

  1. The tests pass in my devcontainer with 3.12.
  2. The doc build complains about an indentation error but I can'f see any issues on the reported line.
tasansal commented 8 months ago

@markspec approved but there's a test conflict; please fix so we can merge. thanks!