search

THCLab / oca-parser-xls

European Union Public License 1.2
1 stars 2 forks source link

Add option to process a JSON file to regenerate the "capture_base" and "digest" hashes #3

Open swcurran opened 1 year ago

swcurran commented 1 year ago

Discussed with @mitfik on a call. Not sure where to put this issue, but it would be nice if this was an option on this tool.

If the OCA Source is managed by JSON, or if the Excel generated JSON needs to be modified in some way, the capture_base and digest generated values will be incorrect any time something is changed. It would be nice (needed?) to have a command lin utility that can add or regenerate those values given a JSON input, producing an accurate OCA Bundle in (at least) JSON and ZIP formats.

My hope is that this feature is internally available in the code already, and this would just be exposing it to be used from the command line.

swcurran commented 1 year ago

BTW -- awesome job on the updated parser. Updating my stuff to match. I really like the outputed XLS file -- interesting stuff!

blelump commented 1 year ago

For OCA Bundle tweaks, it will come with OCAFile support.

Regarding the recent JSON format for OCA Bundle, it is already for quite some time on our plate. The overall concept will slightly change what currently is available in oca-rs. The overview is available here where we are heading. However, it does not include many capture bases in one Bundle feature.

swcurran commented 1 year ago

My $0.02CDN -- the Excel approach is the right way to handle the multiple language changes as the people that will do the translations will know and understand Excel -- much better than they will know/use YAML files stored in GItHub.

I'm OK with the OCAFile approach for some OCA content, but if I think it would be a bad way to go for all of the file. I can see referencing either an Excel file or a JSON file to #include the contents into the OCAFile, but not to manage the entire OCA Bundle (including translations) in the OCAFile. Or I guess have the Excel parser produce YAML instead of JSON. That would be fine with me as well.

I still think the request in this feature is valuable -- taking a manually managed JSON OCA file and updating/inserting the various identifiers that cannot be managed manually.