search

THCLab / oca-parser-xls

European Union Public License 1.2
1 stars 2 forks source link

Bug in parser — Encoding Overlay JSON doesn’t match specs #7

Open swcurran opened 1 year ago

swcurran commented 1 year ago

In the OCA Spec, the JSON for the Character Encoding Overlay uses the item attr_character_encoding, but this OCA Parser implementation generates attribute_character_encoding. The implementation should be updated to match the specification — or vice versa.

swcurran commented 1 year ago

I suspect the fix is just to tweak this line but wasn’t sure if the fix should be in the specification. @blelump, Paul Knowles — what do you think is the right thing to do with this issue?

Thanks!