search

THE-BWC / OpServ-Issues

Repository for all OpServ issues
MIT License
0 stars 0 forks source link

Redacted is shown for own led ops #26

Closed Goltred closed 6 months ago

Goltred commented 6 months ago

When looking at led ops in the jacket, the REDACTED string can be seen for those where thr user apparently has no opsec access.

This was reported by aniron in discord

A decision needs to be made for this situation. Do we keep it as it currently is? Do we remove opsec check in this part because the user led these ops? Do we only show the game name so they can know which game are talking about?

jarnehed commented 6 months ago

Also I am not sure what opsec-enabled op I could have led where I would not have opsec clearance. I have only led Star Citizen operations in the last few years, so this might be a bug in addition to a feature request.

/aniron

PatrickPedersen commented 6 months ago

Okay, that doesn't make sense. The op in question is this: [DRAGON] Strike DRAGMAN Development I (invite only)

You have OPSEC access. Checked the DB to be sure. I also checked the code that changes the data. Everything should work as intended. So, I don't understand why it would show up as Redacted.

PatrickPedersen commented 6 months ago

A decision needs to be made for this situation. Do we keep it as it currently is? Do we remove opsec check in this part because the user led these ops? Do we only show the game name so they can know which game are talking about?

The only thing I would be willing to allow currently is the game name. Anything else would require a much broader discussion with BWC.

jarnehed commented 6 months ago

Interestingly I can see that OP without redactions on my "ops attended" tab, I can open and view it as normal using your link.

It appears the issue affects others as well, Fluff reported several redacted items on her ops led tab.

PatrickPedersen commented 6 months ago

Well, if it's specific to the op-lead menu, that helps greatly with troubleshooting. I'll take a look at it.

PatrickPedersen commented 6 months ago

@jarnehed Pushed a possible fix. Could you please check and see if it works now?

jarnehed commented 6 months ago

@jarnehed Pushed a possible fix. Could you please check and see if it works now?

Appears to have done the trick! I no longer see redacted entries in either my own ops led tab or in Fluff's.

Thanks!

PatrickPedersen commented 6 months ago

Perfect!