search

THE-BWC / OpServ-Issues

Repository for all OpServ issues
MIT License
0 stars 0 forks source link

Removing permissions from "Manage Permissions" broken #4

Open PatrickPedersen opened 6 months ago

PatrickPedersen commented 6 months ago

Removing permissions from ranks in the "Manage Permissions" list, seems to be broken. The permissions aren't being removed.

That page needs an overhaul anyway, so it would be a perfect time to redo the query calls.

Goltred commented 6 months ago

I looked into this a little bit... and unfortunately i have to agree. The reason why this is not working is due to commented out code that deals with permission changes it seems. That being said, when uncommenting it, weird things happened... so i believe is safer to just rework this completely.

One potential suggestion i would make for the future is to split this in multiple pages... where in the "manage permissions" landing page you see all the ranks and their effective permissions. Then you can click in an edit button to change those permissions only for that rank. This would allow to keep queries restricted to the rank being modified instead of trying to synchronize all. If there's still a need to massively change permissions, then that could be another page where you select the permissions you want and then you select the roles you want to assign it to.

PatrickPedersen commented 6 months ago

That would certainly be a better way of doing it. We already do it like that with billets, so why not also ranks.