search

THE-BWC / OpServ-Issues

Repository for all OpServ issues
MIT License
0 stars 0 forks source link

Taskforce/Games list defaults sort order to 9 #6

Open PatrickPedersen opened 8 months ago

PatrickPedersen commented 8 months ago

Taskforce list (and maybe games list) seems to default to sort order nr. 9, which makes the taskforce icons switch upon reload of the page. Temp fix is manually setting the taskforce to sort order nr.1 by moving it somewhere on the list and then back to the top.

The sort function may be broken or the result returned/inserted into the DB is incorrect.

Goltred commented 7 months ago

Where is this issue particularly happening? Is it in the Manage Taskforces option for the admi page or the Taskforces one? Also, do you have an example of this issue happening? Or what is the correct order that should be used?

Looking at the codee, i see that the order seems to be established by the sql query in model/Taskforce.php, with: ORDER BY opserv_games_taskforce.game_id <> 15, game_name ASC, taskforce_name ASC, so i'm assuming that maybe the game_id != 15 could be causing some issues...?

That being said... I think that model operations should rarely have to order things, and potentially leave that to the UI part just because if you ever process these results before displaying them, you might still screw up the order and then it becomes an unnecessary operation.

I can tackle this as soon as i get some extra info on where it is and the desired result :)

PatrickPedersen commented 7 months ago

Well, I thought that it was already left up to the UI. I'll have to dig a little deeper and get you some concrete examples.