adding pip

[m-derakhshan]

Hello. As mentioned in Issue #19, and based on our needs, I tried to add pip to the player while the user minimizes the app and the video is playing. However, this integration is not complete, but you may consider it a starting point.

[m-derakhshan]

Please consider these points:

• as commented in the code, it should integrate with core and pip configuration, so if the user adds pip configuration, it becomes available here. Make this if condition true based on that: https://github.com/THEOplayer/android-ui/pull/51/commits/027fed952ab60a67e849f8651d70ef33d83d42cb#diff-99a58128817a3cbfdecb428f84d1c5c13e8a5e55d22eb6c06bcae7fdee912598R336

• I moved the onPause codes into onStop cause when the user enters the pip mode, the pause is triggered, but we should keep the player playing. I couldn't think of a scenario where onPuase would be necessary over onStop, but if it is, we need to modify the pip helper so that when it goes into pip mode, it plays the video. (there is a method for this. I used to make the video on the full screen. It can be extended)

https://github.com/THEOplayer/android-ui/pull/51/commits/027fed952ab60a67e849f8651d70ef33d83d42cb#diff-99a58128817a3cbfdecb428f84d1c5c13e8a5e55d22eb6c06bcae7fdee912598R552

• Also, there is this issue shown in the video. I don't know if it is due to Pip or if it is full screen.

https://github.com/user-attachments/assets/dc09c3ac-4b6c-4860-9a1b-e2d6b3ffef30

[m-derakhshan]

Thank you. @ceyhun-o @georgechoustoulakis @MattiasBuelens @tvanlaerhoven

[ceyhun-o]

Hi @m-derakhshan,

Thank you very much for your PR!

We will review this and make the necessary changes as soon as possible.

[mammad-derakhshan]

Good morning, May I ask for a time estimate on the integration of PiP in the player? We have an active project, and due to the absence of this feature, we are currently using a custom implementation. Our next release is scheduled for the beginning of January. Should we plan to continue with our custom implementation, or can we expect the built-in PiP feature by then? @ceyhun-o @MattiasBuelens thank you

[ceyhun-o]

Hi @mammad-derakhshan,

I will let you know once we have the planning in place if we can implement this before beginning January.

[mammad-derakhshan]

thank you.

On Tue, Dec 3, 2024 at 9:02 AM ceyhun-o @.***> wrote:

Hi @mammad-derakhshan https://github.com/mammad-derakhshan,

I will let you know once we have the planning in place if we can implement this before beginning January.

— Reply to this email directly, view it on GitHub https://github.com/THEOplayer/android-ui/pull/51#issuecomment-2513802880, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEHALYQMQ6QGEGV3YYEDERT2DVQS3AVCNFSM6AAAAABRUXFYMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJTHAYDEOBYGA . You are receiving this because you were mentioned.Message ID: @.***>