search

THEOplayer / react-native-theoplayer

A React Native THEOplayerView component
https://theoplayer.github.io/react-native-theoplayer/
MIT License
64 stars 21 forks source link

Conflicting frameworks googlecast.xcframework #106

Closed janvandertaelen closed 1 year ago

janvandertaelen commented 1 year ago

When installing version 2.3.0 with config

{ "ios": { "features": [ "GOOGLE_IMA", "CHROMECAST" ] } } We get the error when we run pod install

target has frameworks with conflicting names: googlecast.xcframework.

When we remove CHROMECAST from the features pod install completes

wvanhaevre commented 1 year ago

Are you using any packages that also add a dependency to the Google Cast SDK?

Our THEOplayerGoogleCastIntegration module adds a dependency to google-cast-sdk-dynamic-xcframework, which is a custom cocoapod setup to deliver the Google SDK with M1 support and underlying features like guest mode. If you are for instance depending on react-native-google-cast, which uses a different Google Cast cocoapod setup (google-cast-sdk-dynamic-xcframework-nobluetooth) both dependencies add the googlecast.xcframework as a vendored_framework, which clashes.

wvanhaevre commented 1 year ago

This should be solved through: https://github.com/THEOplayer/react-native-theoplayer/blob/master/doc/cast.md#combining-with-react-native-google-cast

wvanhaevre commented 1 year ago

Confirmed by reporter.