search

THEOplayer / web-ui

UI component library for the THEOplayer Web SDK
https://www.theoplayer.com/docs/open-video-ui/web/
MIT License
10 stars 0 forks source link

Open Video UI for React #48

Closed MattiasBuelens closed 8 months ago

MattiasBuelens commented 9 months ago

Open Video UI for React is a wrapper around Open Video UI for Web. React doesn't always play nicely together with Web Components, so this new library should make it easier to use the Open Video UI within a React app.

The current approach is to publish as a separate package called @theoplayer/react-ui, but keep all releases in lockstep with @theoplayer/web-ui. This means the next release of Web UI (probably 1.6.0) will also be the first release of React UI, which will start at that same version (1.6.0). An alternative approach would be to have separate versions for Web UI and React UI, so they are released independently. Please leave your thoughts in the comments whether you agree or disagree! 🙂

To do:

mrooftho commented 9 months ago

Nice work, great evolution 🎉 ! Personally upvoting 👍 to keep the versioning in lockstep between both.

tjtheo commented 9 months ago

The only thing that I would find strange as an outsider is that we'd probably have react-ui versions without any changelog.

MattiasBuelens commented 9 months ago

The only thing that I would find strange as an outsider is that we'd probably have react-ui versions without any changelog.

The updated changelog script will generate an entry like this:

v1.x.y (2024-01-01)

  • No changes

Should we perhaps add a note to go look at the web-ui changelog?

v1.x.y (2024-01-01)

  • 🏠See changes to [Open Video UI for Web v1.x.y](https://github.com/THEOplayer/web-ui/blob/v1.x.y/CHANGELOG.md)
MattiasBuelens commented 9 months ago

Should we perhaps add a note to go look at the web-ui changelog?

v1.x.y (2024-01-01)

  • 🏠See changes to [Open Video UI for Web v1.x.y](https://github.com/THEOplayer/web-ui/blob/v1.x.y/CHANGELOG.md)

This is now implemented.