THEY-Consulting / they-terraform

Helper modules for an easier terraform life
3 stars 0 forks source link

Feat/14 api gateway with domain regional #20

Closed StarfishM closed 1 year ago

StarfishM commented 1 year ago

Summary

closes #14 Our first try at implementing this didn't sufficiently work with the cp-api setup we have. The reason for this was that in cp-api we have the following setup:

PR instructions

I already checked if this is compatible with cp-api, but if you want to run a double check, you can simulate the scenario we have in cp-api, by changing where you deploy your gateway + domain + cert, by altering line 15 to "eu-west-3" in this file examples/aws/api_gateway_with_domain/providers.tf creating the scenario, where they-code.de has it's root CA in eu-west-1, and you deploy your gateway+plus cert + custom domain in a region differnt to that one.

The steps of acceptance

✔ I executed the PR instructions and everything worked.

✔ I checked the requirements for the ticket, and they are matching the PR.

✔ I am satisfied with the code and left annotations if I had some ideas.

StarfishM commented 1 year ago

only leaving this here and open, for when we need to create the pr for #13 , as that PR integrates all changes from here in a dynamic approach so that we don't loose the api gateway with domain module but only gain a new api gateway with domain mtls module.

StarfishM commented 1 year ago

can now be closed, as we've merged the branch dynamically implementing this.