THEY-Consulting / they-terraform

Helper modules for an easier terraform life
3 stars 0 forks source link

Adapt/Fix zip upload for azure function app #35

Closed xddq closed 6 months ago

xddq commented 1 year ago

Context

While adapting cp-api to use node_modules instead of pnp in yarn v3 we found an issue in they-terraform based on the official archive_file module not supporting globs. Resulting in "package to large" errors when trying to depoy a lambda since all node_modules were in the zip to be uploaded. This was fixed for aws, but could still lead to issues on azure (in case the function app gets to large). Currently we have no issues with azure, but we will/might get them there as well.

NOTE: for azure we need host.json, function.json ( see docu)

Desired Outcome

e2b commented 1 year ago

Just for reference: Here we removed a custom zip builder we used instead of archive_file due to symlink limitation back in the days. This might be a possible starter to implement something similar again as a bug fix: THEY-Consulting/mcp_api#165

pabloheimplatz commented 6 months ago

We close this for now, sorry. :)