closes #36
None of the upgrades done here have any affect on other repos using they-terraform, as all changes strictly apply to our example code, and our example code should be as up to date as possible, so that when we use it as c&p source we use most current state of things.
Examples were using older versions of terraform + providers.
Additionally all libraries were upgraded.
Added two Qol changes:
renamed mtls domain to sth more descriptive, to align with naming style of other examples
adapted cron trigger of example so that whoever tests, doesn't need to manually change this to run a test right after apply
I realised we don't have dependabot running update checks on this, I created a new ticket for this
I also reopened the ticket discussing the necessity of versioning in this repository (see comment on why)
I realised the example: /examples/aws/module_with_specific_provider is running into problems when you try to terraform apply but the same behaviour is exhibited on main, so I created a bug ticket
PR instructions
read through code changes
pick 3-4 random examples and ensure that deployment works, and functions/gateways runs through as expected. (all examples were manually tested before creating this PR, no need to reinvest that time, we need to automate this, but I believe we already have a ticket for that :D...)
note remember to run terrform init --upgrade#
clean up after yourself when you are done terraform destroy
The steps of acceptance
✔ I executed the PR instructions and everything worked.
✔ I checked the requirements for the ticket, and they are matching the PR.
✔ I am satisfied with the code and left annotations if I had some ideas.
Summary
closes #36 None of the upgrades done here have any affect on other repos using they-terraform, as all changes strictly apply to our example code, and our example code should be as up to date as possible, so that when we use it as c&p source we use most current state of things. Examples were using older versions of terraform + providers. Additionally all libraries were upgraded. Added two Qol changes:
I realised we don't have dependabot running update checks on this, I created a new ticket for this I also reopened the ticket discussing the necessity of versioning in this repository (see comment on why) I realised the example:
/examples/aws/module_with_specific_provider
is running into problems when you try toterraform apply
but the same behaviour is exhibited on main, so I created a bug ticketPR instructions
terrform init --upgrade
#terraform destroy
The steps of acceptance
✔ I executed the PR instructions and everything worked.
✔ I checked the requirements for the ticket, and they are matching the PR.
✔ I am satisfied with the code and left annotations if I had some ideas.