"Interval" parameter is called "startTime" after transfer to simulate page

THM-MoTE / webmodelica

A web-based Modelica-Toolbox

https://staging-webmodelica.mni.thm.de/

Mozilla Public License 2.0

8 stars 3 forks source link

"Interval" parameter is called "startTime" after transfer to simulate page #106

Open CSchoel opened 5 years ago

CSchoel commented 5 years ago

Transferring this annotation

annotation(
  experiment(StartTime = 0, StopTime = 50, Tolerance = 1e-6, Interval = 0.002),
  __OpenModelica_simulationFlags(lv = "LOG_STATS", s = "dassl")
);

to the "simulate" page yields these settings:

startTime = 0 (correct)
endTime = 50 (correct)
tolerance = 0.000001 (correct)
startTime = 0.002 (incorrect, should be "interval", not "startTime")

CSchoel commented 5 years ago

I just realized that "interval" is called "stepSize" in webmodelica. To be more general we should stick to the naming conventions of the modelica specification (page 234) and only use the terminology of OpenModelica for OpenModelica-specific parameters.

njustus commented 5 years ago

You are trying to tell me to rename stepSize into interval? Or should i translate interval into stepSize when switching to simulate?

CSchoel commented 4 years ago

To sum it up shortly, we need the following changes:

Rename stepSize to interval in the UI to conform to the Modelica specification and to keep a consistent terminology.
Correctly select the interval parameter in the simulation UI instead of a second "startTime" entry, when the model has an experiment() annotation that sets the Interval parameter.