inconsistent `tool_def` in examples - Githubissues

THUDM / ChatGLM3

ChatGLM3 series: Open Bilingual Chat LLMs | 开源双语对话语言模型

Apache License 2.0

13.19k stars 1.52k forks source link

inconsistent `tool_def` in examples #1268

Closed foldl closed 1 month ago

foldl commented 1 month ago

System Info / 系統信息

Not applicable.

Who can help? / 谁可以帮助到您？

@abmfy We can see two different field names for parameters of a function: params and parameters. Which one is correct? Or both are OK?

https://github.com/THUDM/ChatGLM3/blob/08b01f50dccf540172d9f63e7f23b7e6de0ebc23/tools_using_demo/tool_register.py#L40

https://github.com/THUDM/ChatGLM3/blob/08b01f50dccf540172d9f63e7f23b7e6de0ebc23/composite_demo/tool_registry.py#L44

Information / 问题信息

[X] The official example scripts / 官方的示例脚本
[ ] My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程

Check the code.

Expected behavior / 期待表现

tool_def in two examples shall be the same.